Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clifford label on controlled gates #1090

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Fix Clifford label on controlled gates #1090

merged 4 commits into from
Nov 16, 2023

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Nov 15, 2023 •
edited
Loading

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added the bug Something isn't working label Nov 15, 2023
@renatomello renatomello added this to the Qibo 0.2.3 milestone Nov 15, 2023
@renatomello renatomello self-assigned this Nov 15, 2023
@renatomello renatomello linked an issue Nov 15, 2023 that may be closed by this pull request
Some gates are wrongly reported as Clifford #1089
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad2fd18) 100.00% compared to head (0b0e336) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #1090   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         8857      8854    -3     
=========================================
- Hits          8857      8854    -3
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BrunoLiegiBastonLiegi
BrunoLiegiBastonLiegi approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @renatomello, fine by me.

@renatomello renatomello merged commit 8194acb into master Nov 16, 2023
20 checks passed
@renatomello renatomello deleted the clifford_label branch November 16, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoRobbiati MatteoRobbiati MatteoRobbiati approved these changes

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi approved these changes

@stavros11 stavros11 Awaiting requested review from stavros11

Assignees

@renatomello renatomello

Labels
bug Something isn't working
Projects
None yet
Milestone
Qibo 0.2.3
Development

Successfully merging this pull request may close these issues.

Some gates are wrongly reported as Clifford
3 participants
@renatomello @BrunoLiegiBastonLiegi @MatteoRobbiati